Cannot Request Reviewers on PRs

Question

Cannot Request Reviewers on PRs

Closed this issue 2 years ago · 11 comments

I've opened a PR, but I can't request anyone as a reviewer. Even if I'm not a committer on the project, I'd still like to request a review.

Answer 1 · 2022-05-13T09:51:57.000Z

I've never seen a PR like this where there is no link to any changes. I.e., I see nothing to review. How did you create this PR? From a topic/issue branch in your fork?

Answer 2 · 2022-05-13T09:54:22.000Z

I guess it should be linked to this:

https://github.com/tsmaeder/eclipse.platform.text/tree/562709_fix_size_on_replace

Answer 3 · 2022-05-13T10:12:29.000Z

Even if I'm not a committer on the project, I'd still like to request a review.

You need at least triage access right to the repository to do you as far as I know. You can still simply @<person> mention the one in the PR and ask for a review.

Answer 4 · 2022-05-13T10:24:57.000Z

Would be nice if all Eclipse top-level committers (JDT; PDE, Platform) would have triage rights for all Eclipse top-level repos. @tsmaeder can you open a help ticket request this. I approve as PMC member.

Answer 5 · 2022-05-13T10:29:51.000Z

@vogella FWIW, @tsmaeder is not a committer on eclipse.platform repo ( https://projects.eclipse.org/projects/eclipse.platform/who ), so I don't think there enough reason to shamble the world. It's still possible to ping on comment.
Either we open the capacity to add a reviewer to everyone, or only to committers; everything in-between will bring more complexity IMO.

Answer 6 · 2022-05-13T10:33:41.000Z

@mickaelistria I don't see the increased complexity by allowing JDT committers to assign reviewers in Platform and vice versa but I'm also OK with giving the rights to add reviewer to everyone. I don't assume that the world is just waiting to abuse this power and if this happens we still can change it back.

WDYT?

Answer 7 · 2022-05-13T10:35:33.000Z

WDYT?

I like the idea of opening more "soft management" fields to a wider audience, eg everyone.

Answer 8 · 2022-05-13T10:37:43.000Z

WDYT?

I like the idea of opening more "soft management" fields to a wider audience, eg everyone.

Me too. Anyone against this?

If we have disagreement among committers, I can bring this to the PMC but maybe this time no one dislikes a proposal to change the existing setup?

Answer 9 · 2022-05-13T11:03:23.000Z

@vogella I don't think you can allow everyone to do so but it should be possible to have a "eclipse-commiter" group giving the triage right on all eclipse orgs/projects:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-teams-and-people-with-access-to-your-repository#inviting-a-team-or-person

Answer 10 · 2022-08-28T05:17:15.000Z

Have we made anything here ?

Answer 11 · 2023-03-20T10:54:48.000Z

Have we made anything here ?

Not AFAIK