3 PlatformURLSessionTest fails since I20240920-1800 on all platforms
Closed this issue · 18 comments
Most likely side effect of eclipse-platform/eclipse.platform.releng.aggregator#2369.
Also we have ~100 osgi test errors, see https://download.eclipse.org/eclipse/downloads/drops4/I20240923-0040/testresults/html/org.eclipse.osgi.tests_ep434I-unit-cen64-gtk3-java17_linux.gtk.x86_64_17.html
Common thing seem to be that tests rely on SessionTestExtension / SessionTestSuite / "org.eclipse.pde.junit.runtime.coretestapplication".
Process returned non-zero code: 13 Command: [ eclipseArguments: {data=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/tmp/workspace, os=linux, test=org.eclipse.core.tests.internal.runtime.PlatformURLSessionTest:test0FirstSession, testpluginname=org.eclipse.core.tests.runtime, version=4, testloaderclass=org.eclipse.jdt.internal.junit5.runner.JUnit5TestLoader, application=org.eclipse.pde.junit.runtime.coretestapplication, install=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/workarea/I20240920-1800/eclipse-testing/test-eclipse/eclipse/, port=41739, vm=/opt/tools/java/openjdk/jdk-17/17.0.2+8/bin/java, arch=x86_64, ws=gtk, loaderpluginname=org.eclipse.core.tests.harness, nl=en_US} vmArguments: {} systemProperties: {eclipse.consoleLog=true, osgi.configuration.area.readOnly=false, osgi.configuration.area=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/tmp/eclipse_session_configuration11577756807711097226, org.eclipse.core.tests.session.isRemoteExecution=true, org.eclipse.update.reconcile=false} ]
org.eclipse.core.runtime.CoreException: Process returned non-zero code: 13
Command: [
eclipseArguments: {data=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/tmp/workspace, os=linux, test=org.eclipse.core.tests.internal.runtime.PlatformURLSessionTest:test0FirstSession, testpluginname=org.eclipse.core.tests.runtime, version=4, testloaderclass=org.eclipse.jdt.internal.junit5.runner.JUnit5TestLoader, application=org.eclipse.pde.junit.runtime.coretestapplication, install=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/workarea/I20240920-1800/eclipse-testing/test-eclipse/eclipse/, port=41739, vm=/opt/tools/java/openjdk/jdk-17/17.0.2+8/bin/java, arch=x86_64, ws=gtk, loaderpluginname=org.eclipse.core.tests.harness, nl=en_US}
vmArguments: {}
systemProperties: {eclipse.consoleLog=true, osgi.configuration.area.readOnly=false, osgi.configuration.area=/home/jenkins/agent/workspace/AutomatedTests/ep434I-unit-cen64-gtk3-java17/tmp/eclipse_session_configuration11577756807711097226, org.eclipse.core.tests.session.isRemoteExecution=true, org.eclipse.update.reconcile=false}
]
at org.eclipse.core.tests.harness.session.RemoteTestExecutor.executeRemotely(RemoteTestExecutor.java:66)
at org.eclipse.core.tests.harness.session.SessionTestExtensionHost.interceptTestMethod(SessionTestExtensionHost.java:90)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
ConfigurationSessionTestSuite / CustomSessionConfigurationImpl are used by the PlatformURLSessionTest (and several OSGi tests). These classes need to explicitly specify the explicit and implicit dependencies of for the Eclipse application to be launched in the test. Since eclipse-platform/eclipse.platform.releng.aggregator#2369, org.eclipse.test and all it's dependencies are transitive dependencies of org.eclipse.core.tests.harness, since it is now rexported by org.eclipse.test.performance. So either these dependencies have to be removed or they have to explicitly specified in those classes.
Since the configuration session tests do actually not need the org.eclipse.performance.test dependency, adding all transitive dependencies in the according classes seems unreasonable. This is the problem with all dependencies introduced to org.eclipse.core.tests.harness, as they need ot be added to the configuration session test configurations. Can't we remove the reexport of org.eclipse.test from org.eclipse.performance.test? As an alternative, there was also the proposal to extract the configuration-session-test-specific things to a separate plug-in to avoid these situations: #1333
Can't we remove the reexport of
org.eclipse.testfromorg.eclipse.performance.test?
I can confirm this will fix PlatformURLSessionTest and 100 osgi test fails.
However, there are dependencies in various tests across SDK to org.eclipse.test that has to be fixed first.
What I see in my workspace are these:
- org.eclipse.e4.ui.tests
- org.eclipse.jface.text.tests
- org.eclipse.jdt.debug.tests
- org.eclipse.jdt.core.tests.builder
- org.eclipse.jdt.core.tests.compiler
- org.eclipse.jdt.core.tests.model
Should be doable to fix the dependencies by adding org.eclipse.test to the bundle manifests above
Should be doable to fix the dependencies by adding
org.eclipse.testto the bundle manifests above
@akurtakov : could you please look at that tomorrow, I have to finish my work day now?
I think that the extra added org.eclipse.test bundle dependency shouldn't break any of the tests above.
Should be doable to fix the dependencies by adding
org.eclipse.testto the bundle manifests above@akurtakov : could you please look at that tomorrow, I have to finish my work day now? I think that the extra added
org.eclipse.testbundle dependency shouldn't break any of the tests above.
After pulling in these changes I have these errors:
Description Resource Path Location Type
Bundle 'org.eclipse.test' cannot be resolved MANIFEST.MF /org.eclipse.jdt.core.tests.builder/META-INF line 15 Plug-in Problem
Bundle 'org.eclipse.test' cannot be resolved MANIFEST.MF /org.eclipse.jdt.core.tests.compiler/META-INF line 22 Plug-in Problem
Bundle 'org.eclipse.test' cannot be resolved MANIFEST.MF /org.eclipse.jdt.core.tests.model/META-INF line 20 Plug-in Problem
Working with @jarthana to figure out how to unblock myself.
After pulling in these changes I have these errors
org.eclipse.test project should be imported into workspace.
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test
PlatformURLSessionTest completed normally in https://download.eclipse.org/eclipse/downloads/drops4/I20240923-1800/testResults.php thus closing.
After pulling in these changes I have these errors
org.eclipse.test project should be imported into workspace. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test
That addresses those 3 errors, but I have a few more new ones now:
Description Resource Path Location Type
Bundle 'org.jsoup' cannot be resolved MANIFEST.MF /org.eclipse.platform.doc.tips/META-INF line 13 Plug-in Problem
Document cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 54 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 60 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 84 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 87 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 88 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 96 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 96 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 113 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 116 Java Problem
Element cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 131 Java Problem
Elements cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 56 Java Problem
Elements cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 86 Java Problem
Elements cannot be resolved to a type HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 115 Java Problem
Jsoup cannot be resolved HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 54 Java Problem
The import org.jsoup cannot be resolved HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 34 Java Problem
The import org.jsoup cannot be resolved HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 35 Java Problem
The import org.jsoup cannot be resolved HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 36 Java Problem
The import org.jsoup cannot be resolved HtmlExtractor.java /org.eclipse.platform.doc.tips/src/org/eclipse/platform/doc/tips line 37 Java Problem
Is there a list of projects that are needed from platform.releng.aggregator somewhere ? Sorry a bit clueless (a lot clueless actually :) )
After pulling in these changes I have these errors
org.eclipse.test project should be imported into workspace. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test
I generally download the eclipse-test-framework-*.zip and install the plug-ins from there. Interestingly, I am not finding the framework on the downloads page at all for 4.34 builds. Should I raise a bug or this is intentional?
I was able to close the org.eclipse.platform.doc.tips project and the errors have vanished. Is that OK ?
That addresses those 3 errors, but I have a few more new ones now:
Simply close org.eclipse.platform.doc.tips project, you don't need it.
That addresses those 3 errors, but I have a few more new ones now:
Simply close org.eclipse.platform.doc.tips project, you don't need it.
Cool, done, works :)
After pulling in these changes I have these errors
org.eclipse.test project should be imported into workspace. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/tree/master/eclipse.platform.releng/bundles/org.eclipse.test
I generally download the eclipse-test-framework-*.zip and install the plug-ins from there. Interestingly, I am not finding the framework on the downloads page at all for 4.34 builds. Should I raise a bug or this is intentional?
Install org.eclipse.test feature via p2 from the I-build update site. It is intentionally removed via eclipse-platform/eclipse.platform.releng.aggregator#2337 as a continuation of eclipse-platform/eclipse.platform.releng.aggregator#2332 (which didn't go smooth either due to too convoluted build system).
Alright, thanks gentlemen for your help.
Is there a list of projects that are needed from platform.releng.aggregator somewhere ? Sorry a bit clueless (a lot clueless actually :) )
I find it is always valuable to have a workspace with everything in it:
@mpalat - Please look at this thread for the problems you are facing.
Thanks @HeikoKlare for great hint & @akurtakov for the PR's!
And thanks everyone for the effective and respectful teamwork! 🥇
Thanks everyone - saved a lot of time!