eclipse-theia/theia

@theia/git: missing didCreateFiles filesystem notification when undo a previous file deletion via the git "Discard Changes" button

MikeKoda opened this issue · 3 comments

MikeKoda commented

When using the Theia Git extension (@theia/git) to revert a previously deleted file by selecting "Discard Changes" from the Git view, the file gets correctly restored on the filesystem. However, the expected didCreateFiles (lsp) filesystem notification is not triggered.

Bug Description:

Steps to Reproduce:

  1. Create a new file within a Theia workspace and commit it to the repository.
  2. Delete that file from the file explorer. The change will appear as a deletion in the Git view.
  3. Open the Git view and select "Discard Changes" on the deleted file.
  4. Notice that the file is restored on the filesystem, but the didCreateFiles event is never emitted.

Doing the reverse operation of this i.e. creating a new, unstaged file and Discard the Change triggers the 'didDeleteFiles' notification

Additional Information

  • Operating System:

OSX 14.x

  • Theia Version:
  • 1.56
JonasHelming commented

See also this discussion: #14640

JonasHelming commented

This extension is actually deprecated, see #14640
Is suggest to close this issue.

MikeKoda commented

@theia/git is deprecated