eclipse-tracecompass/org.eclipse.tracecompass

Inconsistent field names for time graph views

awendelin-work opened this issue · 0 comments

When filtering in time graph views ("/" in the Eclipse
version), the user needs to construct a filter using filter
expressions. The filter expressions in general tests values of fields.

The field names are opaque from a user's perspective, and the names
are not created consistently which makes it harder to guess what
fields are available to filter on.

Some fields use lowercase ("label", "entry"), some use
full upper-case ("CPU", "TID"), and some uppercase the first letter
("Start Time", "End Time", "Duration").

The field names are controlled by each time graph dataprovider and are
sometimes dynamically created which does make it harder to enforce
consistency.

Making the fields provided by default consistently
named would be an improvement to set a standard for other fields
(albeit voluntarily). So the basic TimeGraphState could by default
provide fields like:

  • "Label"
  • "Start Time"
  • "End Time"
  • "Duration"

Rather than:

  • "label"
  • "Start Time"
  • "End Time"
  • "Duration"

(Or whichever case you prefer)