[Model Issue]: Serial Part 3.0.0
Opened this issue · 8 comments
URL to Model with Issue
https://github.com/eclipse-tractusx/sldt-semantic-models/tree/main/io.catenax.serial_part/3.0.0
Issue Description
Date regex does not fit the example value.
Schema is not valid to payload!
@catroest means we must change the String example and therefore we have to provide a new SerialPart version (i guess 3.0.1 or 3.1.0)?
@eckardg As this is a part of the Industry Core, could you check?
Edit: I will check in parallel, whether this is wrongly generated by the SAMM-Modelling tool.
@eckardg There are currently two issues that need to be resolved:
- The example for the date information does not match the defined regular expression (only important for schema validation check! Therefore not really critical for implementation in my opinion)
- The existing regular expression for date does not meet all ISO 8601 date formats. The Industry Core Committee should therefore check on whether the regular expression should be adapted or not.
@jSchuetz88 The issues mentioned also concern the Industry Core models Batch 3.0.0 and JustinSequencePart 3.0.0.
@johannsvarela : Thanks for your explanation. I agree to your proposal. Unfortunately I am not knowledgeable enough of modeling to decide about the regex question
@eckardg In dependence of your preferred solution I might be able to help you out.
@johannsvarela @jSchuetz88 Any idea how to fix this or if we are able to fix this for release 25.03? If not, I would remove it from the changes for 25.03 here: eclipse-tractusx/sig-release#986
@markuskeidl This depends on the preferred solution. We can either change the Regexp, but this would be a minor change and could impact the compatibility of technical implementations. Or we could just fix the example, which would not impact the compatibility, thus could be fixed as a hotfix.
If you have a preferred way, I can prepare the Change.