eclipse-uprotocol/up-cpp

clang-tidy: CallbackConnection.h - Variable conversion issues with return value from InvokeResult

Opened this issue · 1 comments

billpittman commented

Just showing the errors since it is probably an easy change:

/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:101:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:117:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:132:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:156:54: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:170:28: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:192:28: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:216:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]
/data/ultifi/up-cpp/test/coverage/datamodel/UuidValidatorTest.cpp:229:11: error: implicit conversion changes signedness: 'std::chrono::duration<long, std::ratio<1, 1000>>::rep' (aka 'long') to 'uint64_t' (aka 'unsigned long') [clang-diagnostic-sign-conversion]

gregmedd commented

@billpittman - it looks like the wrong error log got copied here. Any chance you have the right one?