eclipse-vertx/vert.x

Micrometer configuration lifecycle violation

jonatan-ivanov opened this issue · 2 comments

jonatan-ivanov commented

Micrometer's MeterRegistry should be "configured" (see MeterRegistry.Config) before registering Meter instances to it. For example MeterFilters should be configured before a Meter has been registered to the registry.

Historically, Micrometer has allowed configuring MeterFilters after meters have been registered but due to certain performance optimizations with micrometer-metrics/micrometer#4917 we took a step toward warning users about this situation.

See:

It seems in certain cases Vert.x configures a MeterFilter after a Meter has been registered to the registry causing the warning mentioned above. See micrometer-metrics/micrometer#4920 (comment) by @sanyarnd with a reproducer.

@sanyarnd could you please provide the Vert.x version you are using and any additional details you have?

vietj commented

@jonatan-ivanov can you re-create this issue in this repo please ? vert-x3/vertx-micrometer-metrics#202