eclipse-vertx/vertx-sql-client

DatabaseException#getSqlState is null for MS SQL Server

DavideD opened this issue 10 months ago · 2 comments

DavideD commented 10 months ago

When a new MSSQLException is created, the value of DatabaseException#sqlState is always set to null.

See

vertx-sql-client/vertx-mssql-client/src/main/java/io/vertx/mssqlclient/MSSQLException.java

Line 33 in 0948171

    
           super(formatMessage(number, state, severity, errorMessage, serverName, procedureName, lineNumber), number, null);

The MSSQL JdbcDriver actually has a method to convert the vendor code to the sql state code: https://github.com/microsoft/mssql-jdbc/blob/ebf4d78eb985c7759cc74d4eb3c0de8cd010387d/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerException.java#L333

DavideD commented 10 months ago

I think I can send a fix for this

tsegismont commented 10 months ago

Fixed in 4.x branch by 8a0db88