eclipse/paho.mqtt.c

possible error with read&write Int/Int4 error

jumoog opened this issue · 1 comments

jumoog commented

I'm creating this Bug reported because of the comment on a commit by @bxShop (in case @icraggs missed it)

when publish qos1 message with Packet Identifier 0x00 0x80，this will decoded to a wrong msgid -128，caused the async api Blocking publish on queue full for client。

int readInt(char** pptr) { ... int val = ((((uint8_t)ptr[0]) << 8) | ((uint8_t)ptr[1])); ... }

ed07139#commitcomment-127929331

icraggs commented

I've just reverted that PR. readInt4 and writeInt4 have been changed to return and take unsigned ints rather than ints, so that may help the original issue.