eclipse/tahu

Javascript sparkplug-payload

Opened this issue · 2 comments

alex-controlx commented

I'm working on creating Typescript definitions and notices a few bugs.

tahu/javascript/core/sparkplug-payload/lib/sparkplugbpayload.js

Line 54 in 77bdbe3

PropertyList = SparkplugPayload.lookup('org.eclipse.tahu.protobuf.Payload.PropertyList'),

to be

PropertySetList = SparkplugPayload.lookup('org.eclipse.tahu.protobuf.Payload.PropertySetList'),

tahu/javascript/core/sparkplug-payload/README.md

Line 12 in 77bdbe3

npm install sparkplug-b-payload

to be

npm install sparkplug-payload
ferm10n commented

Hi, you might be interested in #189

alex-controlx commented

I am. Thanks for pointing this out. It looks great, let me know if I can contribute into your pull request.

Below is a link to my conversion (if its' helpful).
https://gist.github.com/alex-controlx/f59d54443b8efdd90dcd1a7cd6c280e3

  • 👍1