TimeoutException for CSS code completion

Question

TimeoutException for CSS code completion

Closed this issue 8 years ago · 14 comments

Every attempt to use completion with CSS language server ends with timeout. I tried to increase timeout (30 sec) but result was the same. I think its related to very large response from CSS LS. After timeout whole JSON response is displayed in log and in console output.

Answer 1 · 2016-11-21T10:27:44.000Z

I can get completion for the color in

a {
  color: <complete here>
}

with master and vscode 1.7.1/02611b40b24c9df2726ad8b33f5ef5f67ac30b44 .
Can you try it?

Answer 2 · 2016-11-21T10:33:49.000Z

I tried completion for properties and for values, always timeout. I'm using master and the same version of vscode.

Answer 3 · 2016-11-21T10:35:03.000Z

Which OS? I'm on Fedora 24.

Answer 4 · 2016-11-21T10:44:57.000Z

Sorry, completion for values is working as you said. Problem is visible with properties.

Which OS? I'm on Fedora 24.

hehe I'm also using Fedora 24. With LSP4J master.

Answer 5 · 2016-11-21T15:11:24.000Z

It looks that there is some kind of hardcoded limitation in Console processing. CSS respose with code completion items is larger than 160000 and IOConsolePartitioner[1] is waiting and blocking other IStreamListener.

[1] https://github.com/eclipse/eclipse.platform.debug/blob/master/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/IOConsolePartitioner.java#L477

Answer 6 · 2016-11-21T15:22:45.000Z

OK, that's a great hint you've found! Ideally we need to move away from having console stream by default. This is useful for dev/debug, but users won't like it. IIRC, I did enable it because it was the 1st working state I could reach, but it's not something we care enough and I'm fine if we drop it to solve this bug.

Answer 7 · 2016-11-22T09:04:34.000Z

Nice to hear that you don't plan to stick with launch configurations. As you said launch configurations are good for now but I believe that future versions should work with pure process. I think I will fix this issue by providing extension point from #96

Answer 8 · 2016-11-22T09:18:38.000Z

I'd like to stick with Launch Configurations for Servers who's lifecycle should be orchestrated by the IDE (Basically if the IDE should start/stop the process). But we definitely need to consider other kinds of servers, that won't be orchestrated by the tool.
Looking at the code, the 'StreamProvider" is simply the interface we need. The Launch Configuration are the most helpful way for user-controllable stuff (if user wants to manually add a new server without a plugin, or tweak a content-type/server associations). But plugin providers should be given a way to define servers without showing it to users as Launch Configuration. That's indeed the topic of #96

Answer 9 · 2016-11-22T09:37:50.000Z

I don't feel comfortable with launch configurations for one reason. Regular user should not see things related to language server internals. Shouldn't be able to shutdown language server manually or delete launch configurations. This will bring a lot of complexity and problems. This is in general Eclipse problem, to much things to control for user ;) Of course everything is a matter of discussion.

Answer 10 · 2016-11-23T08:56:15.000Z

We can use launch configurations without making them visible for the user. That way, they can be provided by third-party plugins. If manual configuration is needed, we can provide a restricted UI, so that users don't get overwhelmed by the many options.

Answer 11 · 2016-11-23T09:20:09.000Z

We can use launch configurations without making them visible for the user

If its possible then maybe its a good idea but still we need to overcome console message size limitation.

@vladdu Can you point me to any example how make such 'custom' launch configurations (I'm not very familiar with launch configurations API).

Answer 12 · 2016-11-23T09:46:15.000Z

@mniewrzal I can't check right now if that is all that is needed, but the ILaunchConfiguration.launch method that has a "register" parameter. By setting it to false, the launch is not visible in the UI. See
http://help.eclipse.org/neon/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/debug/core/ILaunchConfiguration.html#launch-java.lang.String-org.eclipse.core.runtime.IProgressMonitor-boolean-boolean-

Answer 13 · 2016-11-23T10:15:20.000Z

Thanks! I also found attribute ILaunchManager.ATTR_PRIVATE to hide launch configuration from UI. Now I'm trying to not use Console view to display communication.

Answer 14 · 2016-11-30T17:15:05.000Z

I don't really know what to do with this issue. Now that there is an extension to define language server, I don't believe we have to focus much on the Run Configuration console story.
I'm closing this issue as it, but feel free to open bugs (at bugs.eclipse.org ) if there is still something you'd like to see changed here.