eclipselabs/eclipse-language-service

Reorganize plugins

Closed this issue · 8 comments

org.eclipse.languageserver should be spliited into several plugins:

  • org.eclipse.languageserver.core
  • org.eclipse.languageserver.ui
  • org.eclipse.languageserver.csharp.core
  • org.eclipse.languageserver.csharp.ui
  • org.eclipse.languageserver.json.core
  • org.eclipse.languageserver.json.ui
  • org.eclipse.languageserver.css.core
  • org.eclipse.languageserver.css.ui

Can you please elaborate about what would be the content of each of these bundles? I'm unsure splitting core and ui is meaningful there, as this integration has for sole goal to integrate language server in UI.

Commit 2c58077 does extract the language-specific parts to a separated plugin. So everything inside the org.eclipse.languageserver bundle is totally independent from actual instances of language servers.

Thanks @mickaelistria !

Once the launch topic will be clear, we will able to to split org.eclipse.languageserver.languages into:

  • org.eclipse.languageserver.languages.csharp
  • org.eclipse.languageserver.languages.json
  • org.eclipse.languageserver.languages.css

and find a solution to contribute to launch. This split will help the dev of another language (I'm experimenting for TypeScript).

Does typescript server implement the language server protocol?

No, I'm trying to study it. If it's not complex I will implement it.

Get in touch with the Typescript and VSCode people first. I know they plan to ship one together with the regular typescript tools. I can't tell about progress, status nor ETA.
Implementing a language server is going to take some time, and if TypeScript release an official one, yours will be entirely eclipsed by the official one. I'm not sure it's a bankable way to spend resources right now.

Closing as this is not really an issue at the moment. We'll probably have to reconsider how the "languages" bundle is organized as LSP4E or downstream project start shipping actual support for languages with existing language servers.