Submissions/validation
Opened this issue · 4 comments
- Check file format, bounding box, and resolution
-
minioclient
package to transfer from submission to forecast directory - Wrap in a GutHub action triggered by a new submission
Is this what you had in mind @cboettig? Anything else?
examples of GH actions and submit script
https://github.com/eco4cast/tern4cast/blob/main/.github/workflows/submissions.yaml
https://github.com/eco4cast/tern4cast/blob/main/R/submit.R
yup right on!
Couple very initial commits here: https://github.com/eco4cast/modis-lai-forecast/tree/submission-workflow
First I modified spat4cast_submit()
to add some validation steps. It's a work in progress as I have a few questions:
a) I believe we discussed in the last call that we are enforcing bounding boxes and resolution? In that case, we probably need to modify ingest_planetary_data()
to enforce these arguments on a per-site basis. Then the submission checks would be to confirm that the user did not modify any metadata.
b) To perform these checks, I assume we'd need a template. Could we do this with the targets file?
c) Are we only allowing .tif
files?
d) How should each submission be tracked if they are all being added as ensembles to the same directory?
I also made a very simple processes_submissions.R
file to move the submissions from the submissions directory to the forecasts directory. I don't have EFI credentials so I wasn't able to check if it worked. Anything else we would need to include here? The examples from tern4cast
have a lot of user-friendly messages so we can definitely add that.
This looks great, can you open a PR and I'll do a quick code review?