Modify the data type of max and min in Value Properties to float64

Question

Modify the data type of max and min in Value Properties to float64

Closed this issue 2 years ago · 3 comments

cloudxxx8 commented 2 years ago

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata

Description [REQUIRED]

We have the Profile model change in
#770
The change of max and min are missing, and they should be numeric value

Answer 1 · 2023-03-15T07:27:15.000Z

@lenny-intel @iain-anderson after more investigation, @hahattan noticed the min and max default value will be 0 in golang, if we change it to float64. It will cause the incorrect evaluation.

Thus, we decided to revert this change for now.

Answer 2 · 2023-03-17T10:42:07.000Z

Can it work if you make them *float64 and check for nil pointers?

Answer 3 · 2023-03-17T14:09:48.000Z

yes, @iain-anderson , it should work. A new issue is opened for it.
#821