politikedits ip ranges are too broad
edsu opened this issue · 8 comments
@jarib wrote in the austriaedits (now politikedits) pull request #64
A quick glance at the top IPs, it seems to me that you're covering a bit too much. Edits made by universitites/educational institutions aren't really interesting, IMHO.
Your config also has the same range listed multiple times, i.e. it claims that 193.170.0.0/15 belongs to Statistik Austria, Verteidigungsminsiterium, Verkehrsministerium, which isn't going to be helpful (I bet anon will just use the first match, "Statistik Austria", for all edits from there).
I took a look at one tweet:
https://twitter.com/politikedits/status/491513774760001536
If you follow through to the diff you'll see that the IP in question (193.170.127.132) is from a university. The description of the politikedits bot makes it sound like it is only tweeting changes from the Government.
Isn't this problematic?
I'm not sure if you linked the correct Tweet, because this one says "keep in mind, the bot is still in beta" ... ;-)
but yes, it appears some ranges are way to broad and/or wrong. :/
For example, 80.120.0.0/14 is a block contains IPs used be our foreign ministry, but it turned out it belongs to a public ISP. Same with 193.170.0.0/15, which, additional to being a duplicate (or used by two ministries) is a block owned by ACOnet (the academic ISP, which also issues to gov, but not only).
We are having a look, thanks for reporting!
I just fixed the tweet URL in case you are still looking for an example of a false positive.
Sozialministerium and Gesundheitsministerium = 194.232.0.0/16
Familienministerium and Landwirtschaftsministerium = 194.37.72.0/21
Finanzministerium and Bildungsministerium = 85.158.224.0/21
are also wrong (the same), it seems …
Here are some IPs from the Austrian goverment I've found:
78.41.144.0/24: Bundeskanzleramt Wien
78.41.145.0/24: Bundeskanzleramt St. Johann/Pg
78.41.146.0/23: Bundeskanzleramt
78.41.148.0/23: Bundesministerium fuer Inneres, Sektion IV
78.41.150.0/23: Bundeskanzleramt
194.37.4.0 - 194.37.55.255: Bundesministerium fuer Land- und Forstwirtschaft
193.58.210.0 - 193.58.215.255: Bundesrechenzentrum Gmbh
95.131.192.0/21: Bundesrechenzentrum Gmbh
194.232.79.192/27: Bundesministerium fuer europaeische und internationale Angelegenheiten
194.48.236.0/22: Bundesministerium fuer Gesundheit
85.158.226.32/27: Bundesministerium fuer Justiz
193.171.152.0 - 193.171.154.255: Bundesministerium fuer Landesverteidigung
193.171.63.224/28: Bundesministerium fuer Verkehr, Innovation und Technologie
85.158.226.64/26: Bundesministerium fuer Wirtschaft und Arbeit
85.158.226.0/27: Bundesministerium fuer Finanzen
reopening so @stefan2904 can take a look
thanks @daniellehrner, I am currently on "holidays" but I will have a look/crosscheck on sunday. /cc @fatmike182
Closing this since configs are not stored in the anon repository any more, and are the responsibility of the person running anon.
thx again @daniellehrner. merged this in my own repo: stefan2904#1