Would be nice to upgrade to Kotlin 1.3.

Question

Would be nice to upgrade to Kotlin 1.3.

Krzyjan opened this issue 3 years ago · 6 comments

Krzyjan commented 3 years ago

Answer 1 · 2021-09-26T07:18:33.000Z

I agree. Would you like to submit a PR?

Answer 2 · 2021-09-27T09:34:50.000Z

I agree. Would you like to submit a PR?

He-he. It's a loaded question ;-). I am fairly new to Kotlin and TornadoFX. I can give it a shot , though. I would be aiming at Kotlin 1.5.10 and TornadoFX 1.7.20. If you can think of any reason why this wouldn't work, please let me know.

Answer 3 · 2021-09-27T11:22:55.000Z

Hehe, yeah I tried to be sneaky :) Isn't 1.5 still experimental? If that's the case you might want to opt for 1.4, for the samples I guess it doesn't matter much. The core lib might need to be updated as well, and there I think it would be smart to go for latest stable, so perhaps you'd like to do the same her. In any case I don't think it would entail a lot of work. Try it and see what doesn't compile basically.

Answer 4 · 2021-09-29T00:04:18.000Z

Here is my progress report. I have bumped up both Kotlin and TornadoFX to 1.5.21 and 1.7.20 respectively. As you said, compiling was fairly easy. Getting some of it to run proved to be a bit more of a challenge. I have done forms so far. I have also got rid of some of the more annoying Maven warnings. Now, I will be trying to run the other samples.
Let me know, please, if you want me to submit the PR as it stands now, or you would rather wait for the rest?

Answer 5 · 2021-10-03T03:18:12.000Z

I am not sure what the protocol here is. I have created a pull request: #40.

Answer 6 · 2021-10-04T04:01:59.000Z

Since the PR has been merged, I am closing this issue.