Support for custom Icons
stephenjgray opened this issue · 5 comments
stephenjgray commented
Hi,
I have added support for custom icons and styling in a fork of this repo, thought you might want to take a look...
edward-shen commented
Hey! Thanks for the fork!
What you should do next is to make a pull request. I'll formally check what you've done and if everything's good, I'll merge it!
E3V3A commented
@stephenjgray Please post a PR. (And some screenshots showing the new icons.)
edward-shen commented
... Should I just do some git hackery to merge in his changes?
I don't know how ethical that is, but it sounds like he wants to merge?
stephenjgray commented
Hey,
I think I ran into a permissions issue, either with cutting a branch or
pushing changes to it.
Feel free to either pull my changes from the fork or copy and paste them,
or what ever is easiest...
…On Sun, 6 May 2018, 01:18 Edward Shen, ***@***.***> wrote:
... Should I just do some git hackery to merge in his changes?
I don't know how ethical that is, but it sounds like he wants to merge?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFjEZnUkPUqML5Vi-pthhtYxsDZ0wMtPks5tvkFXgaJpZM4RLhi2>
.
edward-shen commented
Closing in favor of #3.