edwtjo/evil-org-mode

broken evil-org-open-links ?

galaunay opened this issue · 2 comments

galaunay commented

Hi,
I downloaded evil-org-mode from Melpa repository,
I'm pretty happy with it, so before anything else, thank you.

I still have some difficulties to use the "evil-org-open-links" function bound to l.
It work fine on external links (such as URL or files) but not with simple headings references ("[[Heading_name]]" that should lead me to the coresponding heading, for example), where emacs freeze (messages buffer displaying "Position saved to mark ring, go back with C-c &. [3028 times]")

I use "org-open-at-point" instead for now, but i'm sure there is a more elegant way to solve this problem.

wsdookadr commented

@muahah I'll first outline what the main goal of evil-org-open-links is. This function was developed so that a user could make a visual selection containing links to URIs that a browser understands(mainly http/https/ftp or local file links) and open all of those links in the visual selection in the browser.
I'm interested in knowing what your use-case is for links like "[[heading_name]]".
I am currently thinking that one way of solving this would be skipping those links or opening them in a different way, but in order to expand further on that I need to know how they are opened.

I use "org-open-at-point" instead for now, but i'm sure there is a more elegant way to solve this problem.

evil-org-open-links does a repeated org-open-at-point over all the links in the visual selection so it's not very different. I'd be interested to know more about how org-open-at-point is working for you and how does it open the links you've mentioned

galaunay commented

@wsdookadr Thanks for the clarifications,
It appears that i misunderstood the use of evil-org-open-links.

I wanted to set a single keybinding to follow link at point in normal state and to follow a set of links in visual mode.

I tried to define a new function org-open-link-or-links in my init.el file to do so :

(defun org-open-link-or-links ()
  (if (memq evil-state '(normal))
      (org-open-at-point)
    (if (memq evil-state '(visual))
    'evil-org-open-links)))

But i have troubles handling evil-org-open-links which is defined as an operator
(does'nt know if you're interested by such function, by the way...).