eerotal/LibreSignage

[color] markup not working inside multiple container since V1.2.0

mauro2306 opened this issue · 7 comments

libresignage error
Hello,

Since the update to V1.2.0 (which was a pain by the way because i was using a data volume to setup some 01-custom.php files manually and the files inside where still pointing to V1.1 and therefore nothing wasn't working anymore), none of my existing slides do apply the color markup correctly anymore, it doesn't give me an error in the editor, but i don't see any change in the preview window, only color text inside the first container work, if i place a second container with columns for example, there it isn't working anymore.

What files exactly were pointing to v1.1.0? LibreSignage should migrate everything automatically unless I've missed something. The problem with colors is certainly interesting as there haven't been any changes to any relevant code between v1.1.0 and v1.2.0.

Hi, files in /var/www/html/config and especially /var/www/html/config/conf where the 01-server-config.php was still in V1.1 instead of V1.2, i wasn't able to login on the main page, the login button wasn't reacting.
I am using the docker version of the app, mounted with 2 volumes, for /var/www/html/config and /var/www/html/data just to be able to modify the files and persist them.

Regarding the color markup, i don't know what to say, look the screenshot i made, i haven't touched the content of my slide in between the 2 versions, now the text remains snow white, like the first markup, the other one have no effect. In the other issues i opened previously, you will find other screenshots where these color markups were applied successfully.

Hello, any news on this ? Thanks for the feedback.

Unfortunately I haven't had the time to look into this yet.

Okay, I figured what's wrong with the slide. There was one change to the markup transpiler: [container] elements are now width: 100% and height: 100% by default because otherwise some slide layouts break. This makes the container in your slide with the "Family Burger" heading take all of the space in the slide and it pushes all other content outside of the screen. One fix is to simply remove the heading container in your markup. I really should make the container height and width configurable via tag properties though.

Hi eerotal, indeed when i change, it does apply the correct layout, but before starting to modify all my [container], any news on that bug or even better on [container] with adjustable height and width ?

Unfortunately I haven't had much time to work on LibreSignage lately so it's not yet possible to adust the width/height. For now, the only way to fix the problem is to modify the markup.