cordova-rtc/cordova-plugin-iosrtc

New libWebRTC build please

saghul opened this issue ยท 9 comments

While testing the H264 support I ran into some shortcoming in the current libWebRTC build bundled with the plugin. Basically it doesn't specify the profile-level-id attribute, but doesn't really use the default (LoL). It also doesn't specify the packetization-mode.

This has since been fixed without the need for ugly workarounds on Chrome > 51, so I guess building the latest libWebRTC should do.

Reference: https://bugs.chromium.org/p/chromium/issues/detail?id=591971

PS: This would also be a good opportunity to tag the 3.0.0 release ๐Ÿ˜‰

/cc @ibc

ibc commented

Let me do it during this week (ping me if necessary)

Thanks! (you'll get the cake once it lands ๐Ÿ˜‰ )

So, howis my build progressing? I have a nice and sweet cake here...

ibc commented

Ping me tomorrow morning please.

Good morning!

ibc commented

libwebrtc updated (being pushed right now) but there are some ObjC changes I must handed in Swift land.

ibc commented

I see this:

a=rtpmap:107 H264/90000
a=rtcp-fb:107 ccm fir
a=rtcp-fb:107 nack
a=rtcp-fb:107 nack pli
a=rtcp-fb:107 goog-remb
a=rtcp-fb:107 transport-cc
a=fmtp:107 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f

good?

YES, that's the Kosher SDP we are after!

๐Ÿฐ ๐Ÿฐ ๐Ÿฐ ๐Ÿฐ