All experiments run with network_rtt after cache way sensitivity analysis was added don't run contention!
solb opened this issue · 2 comments
solb commented
In recent runs on the cachenice_mica2
branch, the contention case was exactly the same as the allocation one!
This bug was introduced by commit 6754023 on line 267 of network_rtt
: notice how the line that launches contention is identical to the one for allocation.
To quickly tell whether a Jaguar file $file
is afflicted, you can run:
$ git log --oneline "`jaguar/jaguar get "$file" meta.commit | cut -d" " -f1`" | grep 6754023 || jaguar/jaguar get "$file" meta.patch | base64 -d | grep '^+.recordtrial contention [^ ]\+ [^ ]\+ [^ ]'
No output/nonzero status means you're good; otherwise, you probably can't trust the contender numbers from that run.
solb commented
Fixed in 8f5f233
. Files starting with zipf99-sensitivity*.txt
(note the lack of a catbench-
prefix) are safe.
solb commented
Actually, someone close this once we've determined the full extent of the resulting confusion.