egoist/bili

[question] Adding rollup-plugin-vue now requires inline-bundle of rollup-plugin-commonjs when generating esm?

xaksis opened this issue · 4 comments

xaksis commented

Adding rollup-plugin-vue now requires including rollup-plugin-commonjs:
https://github.com/vuejs/rollup-plugin-vue#usage

This adds an inline dependency in esm files:
import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';

does this mean we'll have to use --bundleNodeModules?

jofftiquez commented

Same question.

LeCoupa commented

I get the same issue

hosein2398 commented

This is related to rollup-plugin-vue rather Bili, But using --bundle-node-modules seems to fix this for now.
Just consider that this will include all of your imports in bundle, not only this one.

bodograumann commented

In the rollup-plugin-vue docs, I could not find any information regarding this. The author explains it here though: vuejs/rollup-plugin-vue#308 (comment)

Given that bili wants to be “ridiculously easy”, I think it should provide sensible defaults here.