egoist/vue-mugen-scroll

Threshold parameter not working?

alert-debug opened this issue · 0 comments

Thanks for the great work on this useful component!

The JSFiddle demo doesn't demonstrate use of the threshold prop, so I have created one here (which also fixes what I think is a bug in the numbering of the card titles).

It seems to work, with the threshold set to 0.5, but changing it to 0.7 causes the list to no longer grow. Perhaps I'm using it wrong, in which case it would be nice to have the correct use shown in the demo.

While trying to understand how it was supposed to work, I looked at the code in your master branch, and compared it to the code in the npm package. This lead to some confusion, as it seems there are fixes in master that haven't been included in the npm package, even though the package.json in master still lists a version number of 0.2.5.

To improve this situation, please consider at least bumping the version in the package.json (if necessary to something like 0.2.6-pre1) and ideally please release an updated 0.2.6 npm package that includes a fix for the threshold issue (if it really is an issue).

More generally, you might be interested in the discussion about verifying npm packages against their source repos. I tried checking the status of the package against an online verifier and it reported unverified, but that might not be relevant or accurate.