Single quotes not removed from export environment variables
shayaantx opened this issue · 2 comments
Hi,
I had a docker compose block below and the first single quote was preventing the directory from being read which resulted in "WARNING: skipping NFS_EXPORT_0 environment variable since '/downloads is not a container directory"
environment:
- NFS_EXPORT_0='/downloads *(ro,all_squash)'
The culprit code is below:
docker-nfs-server/entrypoint.sh
Line 458 in f97055c
docker-nfs-server/entrypoint.sh
Line 460 in f97055c
We can strip the single quotes easily (see below), lemme know, and I can put up a PR if you want. Might want to consider also stripping double quotes. Or we could make the change against the $line variable before we try to read it into an array.
local dir="${line_as_array[0]//\'/}"
Or lemme know if I'm missing something obvious here.
Thanks
Actually the same single quote stripping would need to happen in the below code too, so probably best to strip single/double quotes right after reading the environment variable
docker-nfs-server/entrypoint.sh
Line 481 in f97055c
nvm I should be wrapping the entire environment variable (including the key in single or double quotes)