eiffel-community/eiffel-intelligence

Remove SubscriptionRepository package

Opened this issue · 0 comments

Description

Remove the classes in "repository" package (SubscriptionRepository + ISubscriptionRepository) and move the code into SubscriptionService class.

Motivation

Remove extra unnecessary layer of calls. The SubscriptionService is already hard coded towards using MongoDB (with MongoQuery) so the extra abstraction doesn't provide any value. MongoDBHandler is used directly by other classes, bypassing the SubscriptionRepository...

Exemplification

Not applicable.

Benefits

Easier to follow the code. Could be more easily refactored in the future (interface towards database).

Possible Drawbacks

Will not improve functionality but rather readability of code.