einsteinx2/WaveBox

Album artists integration into /api/albums broken

mdlayher opened this issue · 3 comments

For example, these album artist names are completely wrong, and the IDs are missing entirely. I'll look more into this later, but being that @einsteinx2 wrote this component, he may be more knowledgeable.

This is causing huge slowdown on /api/albums as well, because of all of the "duplicate" output with different album artist names.

"albums": [
    {
      "itemTypeId": 2,
      "artistId": 394,
      "artistName": "All That Remains",
      "albumArtistId": null,
      "albumArtistName": "30 Seconds to Mars",
      "albumId": 428,
      "albumName": "...For We Are Many",
      "releaseYear": 2010,
      "artId": 440
    },
    {
      "itemTypeId": 2,
      "artistId": 394,
      "artistName": "All That Remains",
      "albumArtistId": null,
      "albumArtistName": "36 Crazyfists",
      "albumId": 428,
      "albumName": "...For We Are Many",
      "releaseYear": 2010,
      "artId": 440
    },
    {
      "itemTypeId": 2,
      "artistId": 394,
      "artistName": "All That Remains",
      "albumArtistId": null,
      "albumArtistName": "3OH!3",
      "albumId": 428,
      "albumName": "...For We Are Many",
      "releaseYear": 2010,
      "artId": 440
    },

Woops :P

I kind of coded this in one session in one day and only did really minimal testing. I should have tested longer before putting into master. I'll fix this week.

Albums stuff and album artists is fixed now. Also improved issues with duplicate albums and searching based on album artist. And albums no longer have a direct association to artist anymore, only album artist.

^^Noticed this this morning. Makes the API a lot more usable for album artists. Thanks.