Test cases assume that multi-dimensional arrays cannot be deserialized
Closed this issue · 4 comments
This is one of several test cases that my msgpack library is failing because my library can _de_serialize it:
Your test case says this type has no constructor:
Which your test pattern then uses to expect deserialization to throw:
Why does it expect deserialization to fail for this? Multi-dimensional arrays are not only constructible, my library is already doing it. :)
FYI see my special handling for arrays, including those with rank > 1:
The property is meant to reflect that the shape has no collection construction strategy. If the visitor is specializing multi-dimensional arrays, then correspondingly the tests would need to specialize that as well.
For the case of Json, I'm filtering out multi-dimensional arrays because the STJ baseline doesn't support them:
And then I use a specialized unit test for the types:
In my workaround, I've stopped using your HasConstructors method. I've actually copied it and removed the multi-dimensional test. It sounds like from what you're saying that that's the best fix and we should close the issue now. Is that right?
I think we can close it for now, but there's definitely room for refininement in how we annotate these test types.