ejbills/DockDoor

Make symbols of traffic lights dark for light mode too

Closed this issue · 8 comments

See this.
image

The current buttons have their x, - and <> transparent white, and it can be hard to read them.
Maybe they could become opaque adapted to the light color as macOS.
I don’t know if this is was planned in #131.

The text inside is in fact white (in DockDoor) and I suggest that it matches the macOS style (especially because the minus of the yellow light is extremely difficult to read).

This seems to be changing according to the light or dark mode, because I use light mode on my Mac and it differs from the changelog screenshot which is dark mode.

image

There will be a fix soon

Capture d’écran 2024-07-10 à 14 53 59

When a window is white, the text inside the buttons is white (because it is transparent).

Why did you close the issue?

Sorry about that, I was thinking it was time to close it. I forgot a PR was intended to close it. It won’t happen again

The logic is that until a fix has been submitted and merged in practice we don't want to close the problem, otherwise it could slip away if at the end of the PR we forget/reject

The logic is that until a fix has been submitted and merged in practice we don't want to close the problem, otherwise it could slip away if at the end of the PR we forget/reject

Thank you for the information!