ejensen/Kindling

Notifications are no longer showing up in Chrome

Closed this issue · 6 comments

clcpolevaulter commented

I am using Version 37.0.2062.120 of Chrome. Notifications have historically worked but are no longer showing up when new messages are posted.

dalibor commented

Same here. I've done some investigation, and it seems to be due to the old Chrome notifications API that's been deprecated in favor of the new one.

mpoush commented

I just tried 4.4.1 in Chrome version 37.0.2062.120 and it's still not 100% fixed - I see popups when I turned off 'Display avatars in notifications', but not when that option is turned onl

ejensen commented

@dalibor The extension uses the latest Chrome APIs for notifications. The Mozilla Developer Network article covers a web notifications API, which Chrome extensions can not use.

The referenced change addresses a new behavior in Chrome where chrome.notifications.create() was erroring with "Unable to successfully use the provided image" when options.iconUrl was not set to a valid image url.

@mpoush Do the notifications work if you disable avatars in notifications? When you receive a new message, can you open the Chrome extensions page (Menu -> Tools -> Extensions), then find Kindling, click the "background page" link, and check for any errors in the console window?

dalibor commented

@ejensen Thanks, your patch fixes this issue for me!

I thought chrome.notifications API is outdated because I am getting undefined in console (wonder why!?), while with the web notifications API I am able to create a notification from console.

mpoush commented

@ejensen Yes, if I disable avatars, it works fine. I noticed these info messages in the console for the campfire page itself:

The page at 'https://' was loaded over HTTPS, but displayed insecure content from 'http://.gif': this content should also be loaded over HTTPS.

I re-enabled avatars, and will let you know if I see are any console errors in Kindling's background page.

mpoush commented

I did get an error:

XMLHttpRequest cannot load http://www.corsproxy.com/dge9rmgqjs8m1.cloudfront.net/global/missing/avatar.gif?r=3. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'chrome-extension://abnakpmgckdkcpgbcejajjbllagggcif' is therefore not allowed access.

When I tried to visit http://www.corsproxy.com/dge9rmgqjs8m1.cloudfront.net/global/missing/avatar.gif?r=3 I found that our corporate firewall blocks anything from corsproxy.com. I was able to load http://dge9rmgqjs8m1.cloudfront.net/global/missing/avatar.gif?r=3