Version discovery regression
Opened this issue · 3 comments
Alexander-Shukaev commented
#352 broke version discovery (made it less robust basically):
which: no nodejs in (/tests/.venv/bin:/opt/bb/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bb/lib64/bin)
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1544, in <module>
main()
File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1126, in main
create_environment(env_dir, args)
File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1011, in create_environment
if node_version_from_args(args) < (0, 6, 3) or args.with_npm:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 188, in node_version_from_args
return parse_version(clear_output(out))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 178, in parse_version
return tuple(map(int, version_str.replace('v', '').split('.')))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '2+2-b20240418T00453999'
ekalinin commented
Hey,
Thanks for the report!
Could you please provide a command where you got an error?
Alexander-Shukaev commented
'/.venv/bin/python3.11', '-mnodeenv', '--prebuilt', '--clean-src', '/.pre-commit/repo2vdt1csj/node_env-system', '-n', 'system'
ekalinin commented
Hey,
Please, try new version - 1.9.1.