eko/gocache

Cannot implement StoreInterface's Invalidate method

sgtsquiggs opened this issue · 4 comments

sgtsquiggs commented

Cannot figure out how we're supposed to implement Invalidate since the invalidation options are private. Cannot retrieve the tags that would be passed to the function.

sgtsquiggs commented

I made some sloppy changes on my fork to expose it. I really don't like it but I needed it in a pinch.

master...sgtsquiggs:gocache:expose-invalidation-options

denis111 commented

the same happens with Set(ctx context.Context, key any, object T, options ...store.Option) because I can't access Option members like expiration...

sgtsquiggs commented

I'll submit a PR and we can get API feedback there.

  • 👍3
eko commented

Hi, thanks to all the people working on this subject.

As options are now publicly available, this should be fixed.

I close this issue for now but feel free to reopen if you still have any issue.