eksahin/google-api-java-client

GoogleClientSecrets javadoc fix

Closed this issue · 2 comments

The javadoc for 
com.google.api.client.googleapis.auth.oauth2.GoogleClientSecrets contains an 
incorrect example, i.e.

 Sample usage:

  static GoogleClientSecrets loadClientSecretsResource(JsonFactory jsonFactory) throws IOException {
    return GoogleClientSecrets.load(
        jsonFactory, SampleClass.class.getResourceAsStream("/client_secrets.json"));
  }


http://javadoc.google-api-java-client.googlecode.com/hg/1.18.0-rc/com/google/api
/client/googleapis/auth/oauth2/GoogleClientSecrets.html


There are no load method signatures that accept an InputStream, only one that 
accepts a java.io.Reader.  Thus the example should be

  static GoogleClientSecrets loadClientSecretsResource(JsonFactory jsonFactory) throws IOException {
    return GoogleClientSecrets.load(
        jsonFactory, new InputStreamReader(SampleClass.class.getResourceAsStream("/client_secrets.json")));
  }

Original issue reported on code.google.com by heue...@gmail.com on 23 Jun 2014 at 10:42

Original comment by wonder...@google.com on 23 Jun 2014 at 10:49

  • Changed state: Accepted
It's fixed in the 1.19.0 Javadoc.

http://javadoc.google-api-java-client.googlecode.com/hg/1.19.0/index.html

Original comment by wonder...@google.com on 14 Sep 2014 at 6:24

  • Changed state: Fixed