Adding ECS formatting to Quarkus
nadworny opened this issue · 1 comments
nadworny commented
Hi there,
I wanted to start a discussion about adding ECS formatting to the Quarkus framework. This issue describes what I was trying to achieve: quarkiverse/quarkus-logging-json#132.
Now I have a working solution and was wondering how I can contribute to his library.
The solution consist of the following code which is based on your classes:
- Serializer: https://gist.github.com/nadworny/5fc96555c5f5d24c919fcacc482e820c
- Formatter: https://gist.github.com/nadworny/a80d405b4b4fc50f6e078ca14f451ab4
My EcsFormatter doesn't extend the Formatter class as it requires a slightly different approach namely it writes directly into the generator.
The final JsonProvider, which uses the quarkus-logging-json framework, looks like this:
@ApplicationScoped
public class EcsJsonProvider implements JsonProvider {
private final EcsQuarkusFormatter ecsFormatter;
@Inject
public EcsJsonProvider(EcsConfiguration ecsConfiguration) {
ecsFormatter = new EcsQuarkusFormatter(ecsConfiguration.service().name(), ecsConfiguration.service()
.nodeName().orElse(null), Boolean.TRUE.equals(ecsConfiguration.logOrigin().orElse(null)),
Boolean.TRUE.equals(ecsConfiguration.errorStackTraceAsArray().orElse(null)));
}
@Override
public void writeTo(JsonGenerator generator, ExtLogRecord event) throws IOException {
ecsFormatter.format(generator, event);
}
}Any suggestions/contributions how we could re-use my code and make it into this library would be greatly appreciated.
mabartos commented
Any progress on this?