flit_core requirement
MiladHeydariaan opened this issue · 5 comments
Hi,
Is there a reason why ecs-logging-python cannot use flit_core 3.x?
I'm having trouble with depending on flit_core 2.x as it is conflicting with our packages.
Thanks
Good question. @sethmlarson do you happen to remember? Otherwise I can look into this.
flit_core is a built-time dependency, not a runtime dependency, and there shouldn't be any potential for conflicts between packages that have different build-time dependencies. How are you seeing an error in this case?
We have build-time dependency conflict because our monorepo build structure is using a different version of flit_core (3+) which happens to be on the dependency graph when I try to build ecs-logging-python.
I patched the version requirement to allow flit_core 3.x and it seems working fine so far. I'm using elasticsearch curator which depends on ecs-logging-python.
As far as I can tell, flit_core 3.0 only had breaking changes that don't affect us.
I don't see any problem with allowing 3.0+. Any objections @sethmlarson?