"Integration Tests" check on master branch is never reported to GitHub
trentm opened this issue · 7 comments
For some reason the "Integration tests" check on commits to master is never reported:
https://github.com/elastic/opbeans-node/commits/master
For example for this commit: 3d14e47
The "pending" "Integration Tests" check links to https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/ which doesn't indicate which build it was. Clicking around, that opbeans-node commit's build trigger this integration test build: https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/15957/
That completed, but the check on the opbeans-node commit has not been updated.
Note that I believe Integration Tests checks are being updated for PRs, e.g. this one: #78
Is someone in @elastic/observablt-robots able to help track down why?
I'm working on it
As far as I see the parameters are passed correctly:
And the githubNotify step is called:
I was somehow thinking the parameters between the obeans-node pipeline and the test-selector pipeline were the root issue, but as far as I see all of the are correct.
I'll keep debugging
I'm a bit confused now :/ since my PR with some verbose traces somehow worked like a charm.
What did I do?
- Raised elastic/apm-integration-testing#1108
- Triggered https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/view/change-requests/job/PR-1108/2/parameters/ with the same parameters that the one used in the master branch -> https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/15957/parameters/
- Log traced mentioned
[INFO] githubCheckNotify: Integration Tests=SUCCESS for elastic/opbeans-node.git@3d14e4774452cf732bcd0023b329ce17863aa2fd
And the GitHub commit status check is not anymore waiting for ->
That points to -> https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/PR-1108/2/display/redirect
I'll rebuild the original build -> https://apm-ci.elastic.co/job/apm-integration-tests-selector-mbp/job/master/15957 and see if the GitHub commit status check gets updated
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-integration-tests-selector-mbp/detail/master/16009/pipeline worked and notified the status
I wonder if the issue was somehow with the GitHub itself though I don't see any incidences in the service:
I'm running a whole new build -> https://apm-ci.elastic.co/job/apm-agent-nodejs/job/opbeans-node-mbp/job/master/74/
Let's see how it goes
I doubt it is GitHub, given this is happening reliably. It also didn't update the check status for this commit yesterday: b0622ef
This is still happening. All master commits show checks are incomplete:
This isn't blocking any work however.