elastic/search-ui

WithSearch: unnecessary child component rerenders

JeroenAdam opened this issue · 1 comments

Maybe a newbie question. Don't hesitate to close if not a bug.
I have a Notes component and a Savedsearches component as children of my WithSearch component, both those children suffer from unnecessary rerenders. The issue occurs when an onClick in the Results component triggers a function to toggle/untoggle a result's detailed view. I tried eliminating all my own code and came to the conclusion it must be related to WithSearch and/or my lack of understanding React.

Component tree
image

Video
You'll see many click actions, look at the children components to the left and the right.
unnecessary-rerenders.webm

Expected behavior
No unnecessary rerenders of child components.

Backend: Elasticsearch, packages: react-search-ui, search-ui-elasticsearch-connector

Solved by replacing PrimeReact Accordion with Reactstrap Accordion.