elastic/support-diagnostics

monitoring import - indexname parameter removed

eddieturizo opened this issue · 1 comments

eddieturizo commented

The indexName parameter for the monitoring import script was removed in 8.1.1 [1]. It is valid for 8.1.0 [2].

Import options [2] suggests indexName is not a valid parameter.

The monitoring import examples suggests indexName is a valid parameter.

While confusing, it would be nice to be able to control the index name unless I'm overlooking a compelling reason not to. It may make sense to consider putting the parameter back or updating the examples to reflect the options table [4].

[1] https://github.com/elastic/support-diagnostics/blob/8.1.1/src/main/java/com/elastic/support/monitoring/MonitoringImportInputs.java
[2] https://github.com/elastic/support-diagnostics/blob/8.1.0/src/main/java/com/elastic/support/monitoring/MonitoringImportInputs.java
[3] https://github.com/elastic/support-diagnostics#monitoring-data-import-options
[4] https://github.com/elastic/support-diagnostics#monitoring-data-import-options

sakurai-youhei commented

Here is my best research and assumption.

  • The indexName was omitted as a part of #425
  • The motivation would be a refactor in the process of implementing #422
  • It seems to be technically possible to revive the indexName.

I might open a PR for this.