Notification icon is ignored on OS X 10.9 and lower

[miniak]

notification_presenter_mac.mm:

  if (base::mac::IsOSYosemiteOrLater() && !icon.drawsNothing())
    notification.contentImage = gfx::SkBitmapToNSImageWithColorSpace(icon, base::mac::GetGenericRGBColorSpace());

What is the reason for ignoring the icon on older versions of OS X?

[anaisbetts]

Older versions of OS X don't support contentImage at all

[miniak]

https://developer.apple.com/library/prerelease/mac/documentation/Foundation/Reference/NSUserNotification_Class/index.html#//apple_ref/occ/instp/NSUserNotification/contentImage

@Property(copy) NSImage *contentImage
Available in OS X v10.9 and later.

[miniak]

I would rewrite it like this:

    if ([notification respondsToSelector:@selector(setContentImage:)] && !icon.drawsNothing())
        notification.contentImage = gfx::SkBitmapToNSImageWithColorSpace(icon, base::mac::GetGenericRGBColorSpace());

[miniak]

#171

[anaisbetts]

Oops, off by one! Should be IsOSMavericksOrLater

[zcbenz]

Fixed by #171.