electron-archive/brightray

Synchronize window resizing on Mac

Closed this issue · 11 comments

evgenyzinoviev commented

Hi all.

Will adding support of this https://code.google.com/p/chromium/issues/detail?id=531831 to brightray fix this electron/electron#3615?

I'm highly interested in that.

zcbenz commented

Looks awesome to me! 👍

evgenyzinoviev commented

So can you add it?

zcbenz commented

I'll add it to my TODO list, no estimate for finish date though.

evgenyzinoviev commented

Thanks!

geeeeeeeeek commented

@zcbenz Is there any update? I'm bothered by this issue recently.

  • 👍2
zcbenz commented

After a closing look, I found actually the original Chromium issue was for their new UI framework on Mac, and after upgrading to Chrome 49, we already have synchronous window resizing in Electron.

evgenyzinoviev commented

Hmm, I can't confirm that it's working (tested on Electron 0.37.2).

zcbenz commented

I tested it by:

  1. Opening the default app
  2. Navigate to a complex site like amazon.com
  3. Make sure devtools is closed
  4. Resize the window and you can notice sync resizing behavior
evgenyzinoviev commented

Try to open more complex site like youtube.com: https://www.youtube.com/watch?v=D699kZYnWYg&feature=youtu.be

zcbenz commented

You will also get the same effect when opening Youtube in Chrome. The synchronous window resizing is not working perfectly, the best we can do is keep the same behavior with Chrome.

davej commented

This is working for manual resize using the cursor but still doesn't seem to be working with win.setSize with animate set to true. Tested on 0.37.7 with devtools closed, here's a video.

Let me know if I should create a new issue for this in Electron/Brightray.

Edit: I think this is an Electron bug rather than Brightray, so commented here: electron/electron#4368