electron-userland/electron-builder

Building on Windows does not write the description from package.json into the FileDescription field of the exe

datadestroyd opened this issue · 2 comments

  • Electron-Builder Version: 24.6.4
  • Node Version: 18.17.1
  • Electron Version: 27.1.2
  • Electron Type (current, beta, nightly): stable
  • Target: windows dir x64

After reading the docs, I expected the description from package.json to be placed in the FileDescription field of the exe, but instead electron-builder places the product name there. After sifting through the source code, I found the line responsible:

const args = [
file,
"--set-version-string",
"FileDescription",
appInfo.productName,

I think the value for FileDescription should be changed to something like appInfo.description || appInfo.productName.

I'm not opposed to that change. But I think that'd classify as a Breaking Change? Right? (just trying to figure out sequencing)