Building on Windows does not write the description from package.json into the FileDescription field of the exe
datadestroyd opened this issue · 2 comments
datadestroyd commented
- Electron-Builder Version: 24.6.4
- Node Version: 18.17.1
- Electron Version: 27.1.2
- Electron Type (current, beta, nightly): stable
- Target: windows dir x64
After reading the docs, I expected the description from package.json to be placed in the FileDescription field of the exe, but instead electron-builder places the product name there. After sifting through the source code, I found the line responsible:
electron-builder/packages/app-builder-lib/src/winPackager.ts
Lines 280 to 284 in 6b84010
I think the value for FileDescription should be changed to something like appInfo.description || appInfo.productName.
mmaietta commented
I'm not opposed to that change. But I think that'd classify as a Breaking Change? Right? (just trying to figure out sequencing)