electron-userland/electron-builder

How to prevent package.json's description from being used as the process name?

dorei44 opened this issue · 8 comments

dorei44 commented
  • Electron-Builder Version: 25.1.8
  • Node Version: 22.8.0
  • Electron Version: 33.0.0
  • Electron Type (current, beta, nightly): current
  • Target: nsis

Somehow the description from package.json is being used as the process name instead of the title? How to change this?

ss1

ss

mmaietta commented

This is new, I've never seen a report of this before.
Was this working this way in a previous electron-builder version? Trying to determine where I can do a git diff from.

dorei44 commented

My build from 2 months ago shows the "correct" behavior which uses "electron-builder": "^24.13.3" and "electron": "^31.4.0"

mmaietta commented

This is the only PR that sticks out to me. #8125
The release previous to that is 25.0.0-alpha.2, would you be willing to give that a test run to help isolate the git diff? (The diff between 24.13.3 and 25.1.8 is HUGE to work with)

dorei44 commented

I gave 25.0.0-alpha.2 a try and it produces the "correct" behavior.

mmaietta commented

Thanks for confirming. I've opened a revert PR and will get this released as soon as possible 🙂

Just to request one further test from you, can you test if this issue was introduced in 25.0.0-alpha.3?

  • 🎉1
dorei44 commented

Yes, the issue occurs in 25.0.0-alpha.3.

mmaietta commented

You're amazing, thanks for the quick confirmation. I have a few other things to get into the next release, but I'll be sure to include the revert as part of it

mmaietta commented

Released in v26.0.0-alpha.3!

Note, the alpha version also migrates to electron/asar and integrates electron/fuses (electron-builder config object electronFuses). Before I had migrated to electron/asar, several new asar unit tests were added to make sure the migration pathway was clean, so all should be fine. Please do let me know if you experience any issues with it though