electron-userland/electron-json-storage

Electron dependency gets packaged into resource

bingqiao opened this issue · 2 comments

bingqiao commented

I think this issue was raised in 133. It is however the electron dependency, not a sample app, being packed into resource.

And that fix in 4.1.2 does not work. Electron dependency still gets packed into win-unpacked\resources\app.asar.unpacked\node_modules by electron-builder. Why does electron need to be a dependency/peerdependency for electron-json-storage? Should it be just devDependencies instead?

This only started happening since 4.1.1.

Thanks

jviotti commented

Hey there!

You're right! Can you try v4.1.4?

bingqiao commented

Yes it now has been fixed. Thanks