file seems to be locked when setting the data after getting the data

Question

file seems to be locked when setting the data after getting the data

jgarza9788 opened this issue 7 years ago · 4 comments

Answer 1 · 2017-10-10T09:55:29.000Z

Is there any chance you can provide a stack trace? ie by printing the error object from the main process?

Answer 2 · 2017-10-10T14:06:41.000Z

I was saving too often. A possible solution was to loop based on the error and re-save.

On Tue, Oct 10, 2017 at 2:55 AM Juan Cruz Viotti ***@***.***> wrote: Is there any chance you can provide a stack trace? ie by printing the error object from the main process? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHtIvlLh3SXFIWtZi3IccsYDdLCS-3kZks5sqz8SgaJpZM4Px1NE> .

-- *Justin Garza* (818) 251-0647 / jgarza9788@gmail.com

Answer 3 · 2017-10-11T01:29:56.000Z

@jgarza9788 Saving too often shouldn't be an issue. The test cases perform stress testing on the module, by very quickly writing a thousand entries, even in parallel (https://github.com/electron-userland/electron-json-storage/blob/master/tests/storage.spec.js#L51). Are you sure there is not something else going on with your app?

Answer 4 · 2018-07-10T00:30:51.000Z

Hi @jgarza9788. Good news! I believe I fixed this issue on this PR: #110. Would you mind giving a shot to confirm the issue is ruled out before merging and publishing?

Basically the problem was that the locking module I was using was not doing real locking, but just some checks in-memory within the same process, so writing the file from more than one process would trigger the issue.

Let me know!