[Bug]: merged pr #42093 "fix: console.log() in AudioWorkletGlobalScope" does not work as expected
Closed this issue · 4 comments
Preflight Checklist
- I have read the Contributing Guidelines for this project.
- I agree to follow the Code of Conduct that this project adheres to.
- I have searched the issue tracker for a bug report that matches the one I want to file, without success.
Electron Version
28.3.1
What operating system are you using?
macOS
Operating System Version
Mac OS X 12.7.1
What arch are you using?
x64
Last Known Working Electron version
28.3.1
Expected Behavior
Weekly builds for branch 28-x-y should be done sucessfully!
Actual Behavior
Failed to build each of time after pr #41895 was merged!
Each time of failed build shows error as follows:
TypeScript compilation failed. Used tsconfig gen/third_party/devtools-frontend/src/front_end/core/sdk/sdk-tsconfig.json
../../third_party/devtools-frontend/src/front_end/core/sdk/ChildTargetManager.ts(177,19): error TS2339: Property 'Worklet' does not exist on type 'typeof Type'.
Testcase Gist URL
No response
Additional Information
This is why I have opened this issue #42204 which has already been closed.
https://app.circleci.com/pipelines/github/electron/electron?branch=28-x-y&status=failed
Are there any one familiar with these codes could help to have a look on it?
Branch 28-x-y has already not been built and released about ONE month, which should be done weekly usually!!!
This pr #42093 (Add support of the Worklet target) looks like trying to resolve this issue, but it seems that it does not work as expect!
Why there are two similar folders name for devtools frontend?
https://github.com/electron/electron/tree/28-x-y/patches/devtools-frontend
https://github.com/electron/electron/tree/28-x-y/patches/devtools_frontend
The same folder name in chromium is:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend
So, it seems the "devtools-frontend" should be the correct folder name!