about mirrorOption version(x.x.x -> vx.x.x)

siaikin opened this issue 5 years ago · 3 comments

siaikin commented 5 years ago

i use this mirror 'https://npm.taobao.org/mirrors/electron/' in china.

in 7.0.0 '@electron/get' request wrong url:
'https://npm.taobao.org/mirrors/electron/v7.0.0/electron-v7.0.0-darwin-x64.zip'

but in 6.1.2 request this url:
'https://npm.taobao.org/mirrors/electron/6.1.2/electron-v6.1.2-darwin-x64.zip'

i seems in this code you sue v${version}. this should be the cause.

ps thanks @nickfan

wells1013 commented 5 years ago

+1

chanble commented 5 years ago

taobao mirror is update cnpm/cnpmjs.org#1551 (comment)

👍2

electron-bot commented 5 years ago

🎉 This issue has been resolved in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀