electron/get

Re-add progress bar by default

NaridaL opened this issue · 1 comments

NaridaL commented

I'm having significant issues with electron's postinstall script. For some reason, I am getting extremely low (~1 kbps) from GitHub Releases. I don't know if it's on my end or GitHub's, everything else is working fine for me.

  1. According to electron/electron-quick-start#127 , doing npm install --verbose electron@7.0.0 should log the download progress, but no such thing is happening.

  2. After figuring out why the script was hanging, https://medium.com/@muellermarkus/download-electron-releases-from-a-faster-mirror-than-github-741bac15c3c9 pointed me to https://www.npmjs.com/package/electron-download

  3. electron-download's homepage redirects to here, but I'm not seeing any reference to a CLI.

  4. electron-download works, but it caches the files without the sanitized url in the file path, while @electron/get does, which means, it's not finding the files I downloaded manually.

If electron-download is deprecated, the NPM package should be marked as such.

The download should log progress by default, that's how https://github.com/GoogleChrome/puppeteer does it for Chromium; hanging on node install.js for 30min with 0 feedback is terrible UX.

chenguanda commented

cache dir is not ~/Library/Caches/electron/ , I use cache dir ~/Library/Caches/electron/httpsnpm.taobao.orgmirrorselectron7.0.1electron-v7.0.1-darwin-x64.zip
and ~/.npmrc

registry=https://registry.npmjs.org/
electron_mirror="https://npm.taobao.org/mirrors/electron/"
electron_custom_dir="7.0.1"

it is work for me when i install 7.0.1

  • 👍2