electron/get

Environment variable usage is not documented

craxal opened this issue · 2 comments

craxal commented

While skimming the source code, I noticed that the mirror URL can also be constructed from environment variables, and not just an options object. What's more, the environment variables take preference over the options object. Not sure if it was intended to leave this little detail out.

Unless that's intended, documentation for this package isn't that great. I'd love to see this improved.

malept commented

We're happy to review a pull request to make this better!

  • 👍1
electron-bot commented

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀