electron/get

Electron version-based regressions

malept opened this issue · 1 comments

While trying to get Electron Packager switched over to use @electron/get instead of electron-download, I found some regressions related to Electron versions:

  • chromedriver special case for Electron < 1.7.0:

    get/lib/index.js

    Lines 102 to 107 in 29708b9

    // Chromedriver started using Electron's version in asset name in 1.7.0
    if (semver.gte(this.version, '1.7.0')) {
    return `chromedriver-${suffix}.zip`
    } else {
    return `chromedriver-v2.21-${type}.zip`
    }
  • Checksums started getting generated in Electron 1.3.2:
    return !this.opts.disableChecksumSafetyCheck && semver.gte(this.version, '1.3.2')

The second bullet point is causing Electron Packager tests to fail.

I suppose the question becomes, what Electron versions should tools support? (Which inevitably becomes a topic for the Docs & Tools WG...) Electron Packager tries to support as many Electron versions as possible; there are still some conditionals for the super-ancient 0.37.x series.

We discussed this in the Docs & Tools WG meeting today. We're going to only "officially" support the versions of Electron officially supported by the Electron team. If it happens to work with earlier versions, that's great, but we're not going to be actively supporting old versions (as in the examples above).