electron-1.8.0 build failed because of this submodule
Closed this issue · 5 comments
I've tried to run the build script, and I got this error.
unning in verbose mode
git submodule sync --recursive
Synchronizing submodule url for 'vendor/boto'
Synchronizing submodule url for 'vendor/breakpad'
Synchronizing submodule url for 'vendor/breakpad/src'
Synchronizing submodule url for 'vendor/crashpad'
Synchronizing submodule url for 'vendor/depot_tools'
Synchronizing submodule url for 'vendor/gyp'
Synchronizing submodule url for 'vendor/libchromiumcontent'
Synchronizing submodule url for 'vendor/native_mate'
Synchronizing submodule url for 'vendor/node'
Synchronizing submodule url for 'vendor/pdf_viewer'
Synchronizing submodule url for 'vendor/requests'
git submodule update --init --recursive
error: no such remote ref 11f2861319ea478de103195e461a6085a4827b31
Fetched in submodule path 'vendor/libchromiumcontent', but it did not contain 11f2861319ea478de103195e461a6085a4827b31. Direct fetching of that commit failed.
None
Traceback (most recent call last):
File "./script/bootstrap.py", line 261, in <module>
sys.exit(main())
File "./script/bootstrap.py", line 34, in main
update_submodules()
File "./script/bootstrap.py", line 133, in update_submodules
execute_stdout(['git', 'submodule', 'update', '--init', '--recursive'])
File "/Users/ning/workspace/electron-game/script/lib/util.py", line 184, in execute_stdout
raise e
subprocess.CalledProcessError: Command '['git', 'submodule', 'update', '--init', '--recursive']' returned non-zero exit status 1
I've tried to clone the repo again and the error is still there.
The remote ref 11f2861 seems valid but dangling.
I run the build successfully right after 1.8.0 released. Is there any rebase or force update to this repo?
A possible solution:
cd vender/libchromiumcontent
git checkout 7cdb1748f625e88c306ce81ad319377293789649
git add vendor/libchromiumcontent
Basically force the git to track a valid hash (committed at Aug 23).
But I don't know why the previous hash got deleted.
Normally cleaning electron and bootstrapping again will fix the above issues 👍 I can successfully build Electron master rn so everything appears to be working correctly
I said it's not a bug for master. It is for 1.8.0. The master is 1.8.1+.
I also said I've cleaned the repo and it didn't work. The cause is a missing hash '11f2861319ea478de103195e461a6085a4827b31' which submitted at Aug 24 (I cloned the repo at the same day, 1.8.0 published at that day). However this commit is not referenced by any branch now.
Anyway, you could close it as won't fix. But it seems dangerous to delete a published commit (by rebase or force update I guess).
FYI, the git log of this repo by
> git log --pretty=format:"%h - %an, %ad : %s"
....// omit irrelevant lines
7c0c64b - Catalin Ionut Fratila, Sat Sep 23 03:22:44 2017 +0200 : Adding patch for v8 Turbofan RCE. (#355)
7cdb174 - John Kleinschmidt, Wed Aug 23 07:58:34 2017 -0400 : Merge pull request #345 from electron/re-enable_debug_mode
....// omit irrelevant lines
Between Aug 23 and Sep 23, there is nothing.
@fantasydr I can see stuff on master from as dates all through that time period (some from 14 days ago for instance)
https://github.com/electron/libchromiumcontent/commits/master my guess is your clone is a little bit messed up for whatever reason
The history is not from my local clone. I didn't paste all logs. My point is about these two lines:
7c0c64b - Catalin Ionut Fratila, Sat Sep 23 03:22:44 2017 +0200 : Adding patch for v8 Turbofan RCE. (#355)
7cdb174 - John Kleinschmidt, Wed Aug 23 07:58:34 2017 -0400 : Merge pull request #345 from electron/re-enable_debug_mode
Your url shows the same thing, there is no commit between Aug 23 and Sep 23.
But 11f2861 is referenced by electron-1.8.0, which got deleted later in this repo.
It was committed at Aug 24. Try to click the url above. I'm not saying electron is broken, but it is possible electron 1.8.0 is broken and it is dangerous to delete a published commit in a popular project.