electron/node-rcedit

Fatal error: Unable to set icon

importre opened this issue · 6 comments

importre commented

Hi.

Packing my electron app for win32, I got Fatal error.
Currently, no icon for win32.

error message

After set icon to "assets/app.icns" for win32,

$ npm run build
...
Packaging app for platform win32 ia32 using electron v0.28.3
fixme:heap:HeapSetInformation 0x0 1 0x0 0
Fatal error: Unable to set icon
 undefined

wine

I've already installed wine using brew.

env

OSX-10.10.3
wine-1.6.2

Deleted user commented

+1 for this

  • Env
    • win10, win7

the args pass to rcedit include --set-icon mypath.ico, but not work.

seanzer commented

When running from node, I get "Fatal error: Unable to commit changes"

When I run from command line, I get no output, but the icon is not set.
rcedit production\layout\electron.exe --set-icon icon.ico

Rensdn commented

rcedit.exe failed with exit code 1. Reserved header is not 0 or image type is not icon for 'p'

ikiK-CRO commented

Still same problem. I have windows 10, and OSX, and I can not set icon on ether system for Windows build.

malept commented

I'm closing this because the latest version of rcedit (which node-rcedit vendors) gives a reason why the icon can't be set. It's not an issue with node-rcedit itself.

liudonghua123 commented

I have the same problems, and finally, I found it was the icon format issue, and I changed the format from png to ico, then it worked.